Re: [PATCH net] xfrm: Fix memory leak of aead algorithm name
flat view
From: Steffen Klassert <steffen.klassert@secunet.com>
Date: 2016-09-19 11:07:54
On Sun, Sep 18, 2016 at 07:42:53AM +0000, Ilan Tayari wrote:
commit 1a6509d99122 ("[IPSEC]: Add support for combined mode algorithms")
introduced aead. The function attach_aead kmemdup()s the algorithm
name during xfrm_state_construct().
However this memory is never freed.
Implementation has since been slightly modified in
commit ee5c23176fcc ("xfrm: Clone states properly on migration")
without resolving this leak.
This patch adds a kfree() call for the aead algorithm name.
Fixes: 1a6509d99122 ("[IPSEC]: Add support for combined mode algorithms")
Signed-off-by: Ilan Tayari <redacted>Applied to the ipsec tree, thanks Ilan!