Thread (23 messages) 23 messages, 4 authors, 2016-09-20

RE: [PATCH net-next 09/10] bnxt_en: Support for "ethtool -r" command

flat view

From: Mintz, Yuval <hidden>
Date: 2016-09-19 08:27:41

Restart autoneg if autoneg is enabled.
+	if (!(link_info->autoneg & BNXT_AUTONEG_SPEED))
+		return -EINVAL;
Looks like a lot of the of implementations of this ethtool
are unconditionally doing the reset.
Perhaps the right thing to do is check for autoneg availability
at the ethtool core itself?

[Not an objection to this patch in any way as there are tens
of implementations doing the same; Simply noting this]
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help