Re: [PATCH v2 net-next 07/16] tcp: track data delivery rate for a TCP connection

On Sat, Sep 17, 2016 at 12:04 PM, kbuild test robot [off-list ref] wrote:

Hi Yuchung,

[auto build test ERROR on net-next/master]

url:    https://github.com/0day-ci/linux/commits/Neal-Cardwell/tcp-BBR-congestion-control-algorithm/20160918-014058
config: x86_64-randconfig-s2-09180225 (attached as .config)
compiler: gcc-4.4 (Debian 4.4.7-8) 4.4.7
reproduce:
        # save the attached .config to linux build tree
        make ARCH=x86_64

All error/warnings (new ones prefixed by >>):

   net/ipv4/tcp_input.c: In function 'tcp_ack':

quoted

quoted

net/ipv4/tcp_input.c:3559: error: unknown field 'v64' specified in initializer
net/ipv4/tcp_input.c:3559: warning: missing braces around initializer

   net/ipv4/tcp_input.c:3559: warning: (near initialization for 'rs.prior_mstamp.<anonymous>')

vim +/v64 +3559 net/ipv4/tcp_input.c

  3553  /* This routine deals with incoming acks, but not outgoing ones. */
  3554  static int tcp_ack(struct sock *sk, const struct sk_buff *skb, int flag)
  3555  {
  3556          struct inet_connection_sock *icsk = inet_csk(sk);
  3557          struct tcp_sock *tp = tcp_sk(sk);
  3558          struct tcp_sacktag_state sack_state;

quoted

3559          struct rate_sample rs = { .prior_mstamp.v64 = 0, .prior_delivered = 0 };

Arg, silly compilers out there.

We can omit prior_mstamp , as the compiler will zero fields anyway

struct rate_sample rs = { .prior_delivered = 0 };