Re: [RFC 02/11] Add RoCE driver framework

On Mon, Sep 12, 2016 at 07:07:36PM +0300, Ram Amrani wrote:

Adds a skeletal implementation of the qed* RoCE driver -
basically the ability to communicate with the qede driver and
receive notifications from it regarding various init/exit events.

Signed-off-by: Rajesh Borundia <redacted>
Signed-off-by: Ram Amrani <redacted>
---

<...>

+
+#define QEDR_MODULE_VERSION	"8.10.10.0"

I am strongly against module versions. You should rely on official
kernel version.

+#define QEDR_NODE_DESC "QLogic 579xx RoCE HCA"
+#define DP_NAME(dev) ((dev)->ibdev.name)