Re: [PATCH net 1/1] net sched actions: fix GETing actions

On 16-09-08 01:12 PM, Cong Wang wrote:

quoted

+}
+
 static int
 tca_action_gd(struct net *net, struct nlattr *nla, struct nlmsghdr *n,
              u32 portid, int event)

@@ -883,6 +894,7 @@ tca_action_gd(struct net *net, struct nlattr *nla, struct nlmsghdr *n,
                        goto err;
                }
                act->order = i;
+               act->tcfa_refcnt+=1;

Maybe we only need to fixup the refcnt without touching list,
from my quick observation to your bug report (again, you didn't explain).

Yes, you are correct. clearing the list is unnecessary since it is
temporary. When i get the chance i will fix it up, test and resubmit.

What do you want the commit message to say? It shows an example because
the functionality broke.

cheers,
jamal