Re: [PATCH next 3/3] ipvlan: Introduce l3s mode

On Fri, Sep 9, 2016 at 3:26 PM, David Ahern [off-list ref] wrote:

On 9/9/16 3:53 PM, Mahesh Bandewar wrote:

quoted

diff --git a/drivers/net/Kconfig b/drivers/net/Kconfig
index 0c5415b05ea9..95edd1737ab5 100644
--- a/drivers/net/Kconfig
+++ b/drivers/net/Kconfig

@@ -149,6 +149,7 @@ config IPVLAN
     tristate "IP-VLAN support"
     depends on INET
     depends on IPV6
+    select NET_L3_MASTER_DEV

depends on instead of select?

The kbuild/kconfig-language.txt suggests that for "depends on" the
option _must_ be selected otherwise menuconfig wont even present the
dependent option while select positively sets the option.

INET and IPv6 are well understood and almost all configs select that.
L3_MASTER is very new and not well understood so chances of someone
_not_ putting them (IPvlan and L3_MASTER) in same context are very
high.