Re: [PATCH net-next V7 4/4] net/sched: Introduce act_tunnel_key

On 16-09-09 06:19 AM, Eric Dumazet wrote:

On Thu, 2016-09-08 at 22:30 -0700, Cong Wang wrote:

quoted

On Thu, Sep 8, 2016 at 9:15 AM, John Fastabend [off-list ref] wrote:

quoted

This should be rtnl_derefence(t->params) and drop the read_lock/unlock
pair. This is always called with RTNL lock unless you have a path I'm
not seeing.

You missed the previous discussion on V6, John.

BTW, you really should follow the whole discussion instead of
jumping in the middle, like what you did for my patchset.
I understand you are eager to comment, but please don't waste
others' time in this way.... Please.

But John is right, and he definitely is welcome to give his feedback
even at V13 if he wants to.

tunnel_key_dump() is called with RTNL being held.

Take a deep breath, vacations, and come back when you are relaxed.

Thanks.

Also v6 discussion was around cleanup() call back I see nothing about
the dump() callbacks. And if there was it wasn't fixed so it should
be resolved.

Anyways Dave/Hadar feel free to submit a follow up patch or v8 it
doesn't much matter to me as noted in the original post.

.John