Re: [PATCH 3/3 v2] net: smsc911x: add wake-up event interrupt support

On Wed, Aug 31, 2016 at 5:27 PM, Jeremy Linton [off-list ref] wrote:

The cleanup code in drv_remove seems to be missing, am I missing something?

No you're right it's just my bad coding. Fixing it and thanks for noticing.

Also, do you want the wake-up to be active if the interface is downed?

Hm! Good point.

It seems most other drivers call
device_set_wakeup_enable() on the device inside a
foo_set_wol() (wake-on-LAN) from the
.set_wol() callback in struct ethtool_ops.

This is in response to the ethtool calls from userspace.

So we need to implement this too.

I don't know whether that has anything to do with whether
the interface is up or not, it seems orthogonal actually.

I will hold this patch back until I can investigate and test
and just resend patches 1+2 right now. (Bindings should
still be OK to merge I guess, and I think the RESET patch
is sorted out.)

Yours,
Linus Walleij