Thread (32 messages) 32 messages, 3 authors, 2016-09-06

Re: [PATCH 02/29] netfilter: physdev: add missed blank

flat view

From: Joe Perches <joe@perches.com>
Date: 2016-09-05 17:43:20
Also in: netfilter-devel

On Mon, 2016-09-05 at 12:58 +0200, Pablo Neira Ayuso wrote:
[]
quoted hunk ↗ jump to hunk
diff --git a/net/netfilter/xt_physdev.c b/net/netfilter/xt_physdev.c
[]
quoted hunk ↗ jump to hunk
@@ -107,8 +107,8 @@ static int physdev_mt_check(const struct xt_mtchk_param *par)
 	     info->invert & XT_PHYSDEV_OP_BRIDGED) &&
 	    par->hook_mask & ((1 << NF_INET_LOCAL_OUT) |
 	    (1 << NF_INET_FORWARD) | (1 << NF_INET_POST_ROUTING))) {
-		pr_info("using --physdev-out and --physdev-is-out are only"
-			"supported in the FORWARD and POSTROUTING chains with"
+		pr_info("using --physdev-out and --physdev-is-out are only "
+			"supported in the FORWARD and POSTROUTING chains with "
 			"bridged traffic.\n");
 		if (par->hook_mask & (1 << NF_INET_LOCAL_OUT))
 			return -EINVAL;
Perhaps it would be reasonable at some point to coalesce
all the string fragments.

Maybe using this could help:

$ git ls-files -- "net/netfilter/*.[ch]" | \
  xargs ./scripts/checkpatch.pl  -f --types=split_string --fix-inplace
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help