Thread (15 messages) 15 messages, 5 authors, 2017-01-31

Re: [Patch net-next 2/2] netns: avoid disabling irq for netns id

From: Nicolas Dichtel <hidden>
Date: 2016-09-02 08:12:25

Le 02/09/2016 à 06:53, Cong Wang a écrit :
We never read or change netns id in hardirq context,
the only place we read netns id in softirq context
is in vxlan_xmit(). So, it should be enough to just
disable BH.
Are you sure? Did you audit all part of the code?
peernet2id() is called from netlink core system (do_one_broadcast()). Are you
sure that no driver call this function from an hard irq context?

I think that NETLINK_LISTEN_ALL_NSID is largely untested, so it will be hard to
detect a bug introduced in this feature.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help