Re: possible circular locking dependency detected

On Thu, Sep 1, 2016 at 2:43 PM, Linus Torvalds
[off-list ref] wrote:

On Thu, Sep 1, 2016 at 2:01 PM, Al Viro [off-list ref] wrote:

quoted

Outside as in "all fs activity in bind happens under it".  Along with
assignment to ->u.addr, etc.  IOW, make it the outermost lock there.

Hah, yes. I misunderstood you.

Yes. In fact that fixes the problem I mentioned, rather than introducing it.

So the easiest approach would seem to be to revert commit c845acb324aa
("af_unix: Fix splice-bind deadlock"), and then apply the lock split.

Like the attached two patches.

This is still *entirely* untested.

Rainer?

                 Linus