Re: [PATCH 3/6] net: bcmgenet: constify ethtool_ops structures
From: Florian Fainelli <f.fainelli@gmail.com>
Date: 2016-08-31 17:08:57
Also in:
kernel-janitors, lkml
On 08/31/2016 12:30 AM, Julia Lawall wrote:
Check for ethtool_ops structures that are only stored in the ethtool_ops field of a net_device structure or passed as the second argument to netdev_set_default_ethtool_ops. These contexts are declared const, so ethtool_ops structures that have these properties can be declared as const also. The semantic patch that makes this change is as follows: (http://coccinelle.lip6.fr/) // <smpl> @r disable optional_qualifier@ identifier i; position p; @@ static struct ethtool_ops i@p = { ... }; @ok1@ identifier r.i; struct net_device e; position p; @@ e.ethtool_ops = &i@p; @ok2@ identifier r.i; expression e; position p; @@ netdev_set_default_ethtool_ops(e, &i@p) @bad@ position p != {r.p,ok1.p,ok2.p}; identifier r.i; @@ i@p @depends on !bad disable optional_qualifier@ identifier r.i; @@ static +const struct ethtool_ops i = { ... }; // </smpl> Signed-off-by: Julia Lawall <redacted>
Acked-by: Florian Fainelli <f.fainelli@gmail.com> -- Florian