Thread (1 message) 1 message, 1 author, 2016-08-30

Re: [PATCH v4] brcmfmac: add missing header dependencies

From: Kalle Valo <hidden>
Date: 2016-08-30 16:08:42
Also in: linux-wireless, lkml

Baoyou Xie [off-list ref] writes:
On 29 August 2016 at 23:31, Rafał Miłecki [off-list ref] wrote:

    On 29 August 2016 at 14:39, Baoyou Xie [off-list ref] wrote:
    > We get 1 warning when build kernel with W=1:
    > drivers/net/wireless/broadcom/brcm80211/brcmfmac/tracepoint.c:23:6:
    warning: no previous prototype for '__brcmf_err' [-Wmissing-prototypes]

    building? I'm not native English, but I think so.
   

    > In fact, this function is declared in brcmfmac/debug.h, so this patch
    > add missing header dependencies.

    adds
   

    > Signed-off-by: Baoyou Xie [off-list ref]
    > Acked-by: Arnd Bergmann [off-list ref]

    Please don't resend patches just to add tags like that. This only
    increases a noise and patchwork handles this just fine, see:
    https://patchwork.kernel.org/patch/9303285/
    https://patchwork.kernel.org/patch/9303285/mbox/


Do I need to resend a patch that fixes two typos(build/add)? or you modify them
on your way?
I can fix those when I commit the patch.

-- 
Kalle Valo
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help