Re: [PATCH for-next 0/2] {IB,net}/hns: Add support of ACPI to the Hisilicon RoCE Driver

On 8/25/2016 8:08 AM, Salil Mehta wrote:

quoted

-----Original Message-----
From: Doug Ledford [mailto:dledford@redhat.com]
Sent: Thursday, August 25, 2016 12:57 PM
To: David Miller; Salil Mehta
Cc: Huwei (Xavier); oulijun; Zhuangyuzeng (Yisen);
mehta.salil.lnk@gmail.com; linux-rdma@vger.kernel.org;
netdev@vger.kernel.org; linux-kernel@vger.kernel.org; Linuxarm
Subject: Re: [PATCH for-next 0/2] {IB,net}/hns: Add support of ACPI to
the Hisilicon RoCE Driver

On 8/25/2016 12:53 AM, David Miller wrote:

quoted

From: Salil Mehta <redacted>
Date: Wed, 24 Aug 2016 04:44:48 +0800

quoted

This patch is meant to add support of ACPI to the Hisilicon RoCE

driver.

quoted

quoted

Following changes have been made in the driver(s):

Patch 1/2: HNS Ethernet Driver: changes to support ACPI have been

done in

quoted

quoted

   the RoCE reset function part of the HNS ethernet driver. Earlier

it only

quoted

quoted

   supported DT/syscon.

Patch 2/2. HNS RoCE driver: changes done in RoCE driver are meant to

detect

quoted

quoted

   the type and then either use DT specific or ACPI spcific

functions. Where

quoted

quoted

   ever possible, this patch tries to make use of "Unified Device

Property

quoted

quoted

   Interface" APIs to support both DT and ACPI through single

interface.

quoted

quoted

NOTE 1: ACPI changes done in both of the drivers depend upon the

ACPI Table

quoted

quoted

     (DSDT and IORT tables) changes part of UEFI/BIOS. These changes

are NOT

quoted

quoted

     part of this patch-set.
NOTE 2: Reset function in Patch 1/2 depends upon the reset function

added in

quoted

quoted

     ACPI tables(basically DSDT table) part of the UEFI/BIOS. Again,

this

quoted

quoted

     change is NOT reflected in this patch-set.

I can't apply this series to my tree because the hns infiniband

driver

quoted

doesn't exist in it.

No.  This probably needs to go through my tree.  Although with all of
the requirements, I'm a bit concerned about those being present
elsewhere.

--
Doug Ledford [off-list ref]
    GPG Key ID: 0E572FDD

Hello Doug,
Thanks for your reply. I have just replied to David email as well and did
not realize your response was already on the way. Sorry for this!

I would just like to request, if by any chance, we can expedite the acceptance
of the below patch (part of patch-set) in the net-next. This might help you as
well in future when you will actually push the RoCE driver to the linux-next.

"[PATCH for-next 1/2] net: hns: Add support of ACPI to HNS driver RoCE Reset
 function"

Below HNS RoCE reset function patch has already been accepted by Dave Miller and
is part of net-next,
https://patchwork.kernel.org/patch/9287497/

Also, above ACPI support of RoCE Reset patch cleanly applies over the already
accepted patch in the link and is not dependent on other accompanying RoCE
driver ACPI changes or even the presence of the Infiniband/RoCE Driver in the
net-next repository.

Could you please suggest if this the something which can be considered?   

I've pulled both of these patches in.  I usually merge late in the merge
window, so it won't be any stretch to wait until the ACPI tree has been
merged before I send Linus my pull request.


-- 
Doug Ledford [off-list ref]
    GPG Key ID: 0E572FDD