Re: [PATCH] net: macb: Increase DMA buffer size
From: Nicolas Ferre <hidden>
Date: 2016-08-24 19:17:17
Also in:
lkml
Le 24/08/2016 à 20:25, Xander Huff a écrit :
quoted hunk ↗ jump to hunk
From: Nathan Sullivan <redacted> In recent testing with the RT patchset, we have seen cases where the transmit ring can fill even with up to 200 txbds in the ring. Increase the size of the DMA rings to avoid overruns. Signed-off-by: Nathan Sullivan <redacted> Acked-by: Ben Shelton <redacted> Acked-by: Jaeden Amero <redacted> Natinst-ReviewBoard-ID: 83662 --- drivers/net/ethernet/cadence/macb.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)diff --git a/drivers/net/ethernet/cadence/macb.c b/drivers/net/ethernet/cadence/macb.c index 3256839..86a8e20 100644 --- a/drivers/net/ethernet/cadence/macb.c +++ b/drivers/net/ethernet/cadence/macb.c@@ -35,12 +35,12 @@ #include "macb.h" -#define MACB_RX_BUFFER_SIZE 128 +#define MACB_RX_BUFFER_SIZE 1536
This change seems not covered by the commit message. Can you please separate the changes in 2 patches or elaborate a bit more the reason for this RX buffer size change. Bye,
#define RX_BUFFER_MULTIPLE 64 /* bytes */ #define RX_RING_SIZE 512 /* must be power of 2 */ #define RX_RING_BYTES (sizeof(struct macb_dma_desc) * RX_RING_SIZE) -#define TX_RING_SIZE 128 /* must be power of 2 */ +#define TX_RING_SIZE 512 /* must be power of 2 */ #define TX_RING_BYTES (sizeof(struct macb_dma_desc) * TX_RING_SIZE) /* level of occupied TX descriptors under which we wake up TX process */
-- Nicolas Ferre