Re: net: Zeroing the structure ethtool_wolinfo in ethtool_get_wol()
From: Joe Perches <joe@perches.com>
Date: 2016-08-23 14:10:09
Also in:
lkml
On Tue, 2016-08-23 at 14:41 +0100, Luis Henriques wrote:
From: Avijit Kanti Das <redacted> memset() the structure ethtool_wolinfo that has padded bytes but the padded bytes have not been zeroed out.
I expect there are more of these in the kernel tree. While this patch is strictly true and the behavior is not guaranteed by spec, what compilers do not memset then set the specified member? Every time I've looked, gcc does.
quoted hunk ↗ jump to hunk
diff --git a/net/core/ethtool.c b/net/core/ethtool.c
[]
quoted hunk ↗ jump to hunk
@@ -1435,11 +1435,13 @@ static int ethtool_reset(struct net_device *dev, char __user *useraddr)static int ethtool_get_wol(struct net_device *dev, char __user *useraddr) { - struct ethtool_wolinfo wol = { .cmd = ETHTOOL_GWOL }; + struct ethtool_wolinfo wol; if (!dev->ethtool_ops->get_wol) return -EOPNOTSUPP; + memset(&wol, 0, sizeof(struct ethtool_wolinfo)); + wol.cmd = ETHTOOL_GWOL; dev->ethtool_ops->get_wol(dev, &wol); if (copy_to_user(useraddr, &wol, sizeof(wol)))