Thread (7 messages) 7 messages, 4 authors, 2016-08-23

Re: [PATCH] checkpatch: See if modified files are marked obsolete in MAINTAINERS

From: SF Markus Elfring <hidden>
Date: 2016-08-22 20:50:51
Also in: kernel-janitors, linux-wireless, lkml

quoted hunk ↗ jump to hunk
@@ -2289,6 +2299,10 @@ sub process {
 		}
 
 		if ($found_file) {
+			if (is_maintained_obsolete($realfile)) {
+				WARN("OBSOLETE",
+				     "$realfile is marked as 'obsolete' in the MAINTAINERS hierarchy.  No unnecessary modifications please.\n");
+			}
How do you think about to avoid a double negation in such a warning message?

Would a wording like "… Only really necessary modifications please.\n"
be more useful here?

Regards,
Markus
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help