Re: [PATCH 2/2] tun: Rename a jump label in update_filter()
From: "Michael S. Tsirkin" <mst@redhat.com>
Date: 2016-08-22 01:41:19
Also in:
kernel-janitors, lkml
On Sat, Aug 20, 2016 at 09:37:16AM +0200, SF Markus Elfring wrote:
From: Markus Elfring <redacted> Date: Sat, 20 Aug 2016 09:00:34 +0200 Adjust a jump target according to the Linux coding style convention. Signed-off-by: Markus Elfring <redacted>
I don't have an opinion of this one. Which convention do you refer to?
quoted hunk ↗ jump to hunk
--- drivers/net/tun.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-)diff --git a/drivers/net/tun.c b/drivers/net/tun.c index a1aeccb..e249428 100644 --- a/drivers/net/tun.c +++ b/drivers/net/tun.c@@ -753,7 +753,7 @@ static int update_filter(struct tap_filter *filter, void __user *arg) for (; n < uf.count; n++) { if (!is_multicast_ether_addr(addr[n].u)) { err = 0; /* no filter */ - goto done; + goto free_addr; } addr_hash_set(filter->mask, addr[n].u); }@@ -769,8 +769,7 @@ static int update_filter(struct tap_filter *filter, void __user *arg) /* Return the number of exact filters */ err = nexact; - -done: +free_addr: kfree(addr); return err; }-- 2.9.3