Thread (8 messages) 8 messages, 4 authors, 2016-09-26

Re: [PATCH 2/3] hostap: Delete an unnecessary jump label in prism2_ioctl_priv_hostapd()

From: Julian Calaby <hidden>
Date: 2016-08-21 01:46:05
Also in: kernel-janitors, linux-wireless, lkml

Hi Marcus,

On Sun, Aug 21, 2016 at 2:46 AM, SF Markus Elfring
[off-list ref] wrote:
quoted hunk ↗ jump to hunk
From: Markus Elfring <redacted>
Date: Sat, 20 Aug 2016 18:21:29 +0200

Remove a jump label which is unneeded in this function at the end.

Signed-off-by: Markus Elfring <redacted>
---
 drivers/net/wireless/intersil/hostap/hostap_ioctl.c | 6 ++----
 1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/drivers/net/wireless/intersil/hostap/hostap_ioctl.c b/drivers/net/wireless/intersil/hostap/hostap_ioctl.c
index 4e271f9..5942917 100644
--- a/drivers/net/wireless/intersil/hostap/hostap_ioctl.c
+++ b/drivers/net/wireless/intersil/hostap/hostap_ioctl.c
@@ -3835,14 +3835,12 @@ static int prism2_ioctl_priv_hostapd(local_info_t *local, struct iw_point *p)
        }

        if (ret == 1 || !ap_ioctl) {
-               if (copy_to_user(p->pointer, param, p->length)) {
+               if (copy_to_user(p->pointer, param, p->length))
                        ret = -EFAULT;
-                       goto out;
-               } else if (ap_ioctl)
+               else if (ap_ioctl)
                        ret = 0;
        }

- out:
Does this change make any difference to the compiled code?

Thanks,

-- 
Julian Calaby

Email: julian.calaby@gmail.com
Profile: http://www.google.com/profiles/julian.calaby/
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help