Re: [PATCH] mwifiex: propagate error if IRQ request fails in mwifiex_sdio_of()
From: Arend van Spriel <arend.vanspriel@broadcom.com>
Date: 2016-08-19 01:00:39
Also in:
linux-wireless, lkml
On 18-08-16 16:17, Javier Martinez Canillas wrote:
If request_irq() fails in mwifiex_sdio_probe_of(), only an error message is printed but the actual error is not propagated to the caller function.
Hmm. The caller function, ie. mwifiex_sdio_probe(), does not seem to care. The device may still function without this wake interrupt. Regards, Arend
quoted hunk ↗ jump to hunk
Signed-off-by: Javier Martinez Canillas <redacted> --- drivers/net/wireless/marvell/mwifiex/sdio.c | 1 + 1 file changed, 1 insertion(+)diff --git a/drivers/net/wireless/marvell/mwifiex/sdio.c b/drivers/net/wireless/marvell/mwifiex/sdio.c index d3e1561ca075..00727936ad6e 100644 --- a/drivers/net/wireless/marvell/mwifiex/sdio.c +++ b/drivers/net/wireless/marvell/mwifiex/sdio.c@@ -125,6 +125,7 @@ static int mwifiex_sdio_probe_of(struct device *dev, struct sdio_mmc_card *card) dev_err(dev, "Failed to request irq_wifi %d (%d)\n", cfg->irq_wifi, ret); + return ret; } disable_irq(cfg->irq_wifi); }