Re: [PATCH] net: macb: add phy-handle support for the macb
From: David Miller <davem@davemloft.net>
Date: 2016-08-14 08:58:25
Also in:
linux-devicetree, lkml
From: Kedareswara rao Appana <appana.durga.rao@xilinx.com> Date: Sat, 13 Aug 2016 15:31:49 +0530
quoted hunk ↗ jump to hunk
@@ -445,7 +445,13 @@ static int macb_mii_init(struct macb *bp) dev_set_drvdata(&bp->dev->dev, bp->mii_bus); np = bp->pdev->dev.of_node; - if (np) { + np1 = of_get_parent(bp->phy_node); + if (np1) { + of_node_put(np1); + err = of_mdiobus_register(bp->mii_bus, np1); + if (err) + goto err_out_unregister_bus; + } else if (np) {
I don't know about this, all OF nodes other than the root have a parent node which is non-NULL. This parent node can be anything. Just blinding assuming that any parent node of the phy_node is what we are looking for, without any other supplementary checks at all, seems to be asking for trouble at the very least.