Re: [PATCH v2] drivers: net: cpsw: fix kmemleak false-positive reports for sk buffers
From: David Miller <davem@davemloft.net>
Date: 2016-08-11 01:00:22
Also in:
linux-omap, lkml
From: Grygorii Strashko <grygorii.strashko@ti.com> Date: Wed, 10 Aug 2016 20:02:53 +0300
quoted hunk ↗ jump to hunk
diff --git a/drivers/net/ethernet/ti/cpsw.c b/drivers/net/ethernet/ti/cpsw.c index 0805855..5caef77 100644 --- a/drivers/net/ethernet/ti/cpsw.c +++ b/drivers/net/ethernet/ti/cpsw.c@@ -732,6 +732,11 @@ static void cpsw_rx_handler(void *token, int len, int status) netif_receive_skb(skb); ndev->stats.rx_bytes += len; ndev->stats.rx_packets++; + /* SKB pointer will be stored in CPPI RAM (SRAM) which belongs + * to MMIO space, as result false positive memory leak report + * will be generated. + */ + kmemleak_not_leak(new_skb); } else { ndev->stats.rx_dropped++; new_skb = skb;
There is already a kmemleak_not_leak() statement here in the current driver. Please always develop and generate patches against current sources.