Thread (5 messages) flat view 5 messages, 2 authors, 2016-08-05

Re: [PATCH 08/11] net/fsl: use of_property_read_bool

From: Julia Lawall <hidden>
Date: 2016-08-05 10:08:44
Also in: kernel-janitors, lkml


On Fri, 5 Aug 2016, Johannes Berg wrote:
quoted
-	if (of_get_property(pdev->dev.of_node,
-			    "little-endian", NULL))
+	if (of_property_read_bool(pdev->dev.of_node, "little-
endian"))
 		priv->is_little_endian = true;
 	else
 		priv->is_little_endian = false;
Perhaps, while changing this, that'd be better as

	priv->is_little_endian = of_property_read_bool(...);

Obviously that would've worked before, but now it'd be even easier to
understand, it seems.
Can I do the same for:

	if (of_property_read_bool(np, "phy-clk-valid"))
                pdata->check_phy_clk_valid = 1;
	else
                pdata->check_phy_clk_valid = 0;

The type is not bool, but:

include/linux/fsl_devices.h:    unsigned        check_phy_clk_valid:1;

thanks,
julia
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help