Thread (2 messages) flat view 2 messages, 2 authors, 2016-08-03

RE: [PATCH 0071/1285] Replace numeric parameter like 0444 with macro

From: David Laight <hidden>
Date: 2016-08-03 15:49:56
Also in: lkml

From: Baole Ni
Sent: 02 August 2016 11:39
I find that the developers often just specified the numeric value
when calling a macro which is defined with a parameter for access permission.
As we know, these numeric value for access permission have had the corresponding macro,
and that using macro can improve the robustness and readability of the code,
thus, I suggest replacing the numeric parameter with the macro.
...
-module_param(debug, ulong, 0644);
+module_param(debug, ulong, S_IRUSR | S_IWUSR | S_IRGRP | S_IROTH);
...

If you're as old as I am the octal constant is easier to read!

	David
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help