Re: [PATCH 1115/1285] Replace numeric parameter like 0444 with macro
From: Eric W. Biederman <hidden>
Date: 2016-08-02 16:13:29
Also in:
lkml, netfilter-devel
Baole Ni [off-list ref] writes:
I find that the developers often just specified the numeric value when calling a macro which is defined with a parameter for access permission. As we know, these numeric value for access permission have had the corresponding macro, and that using macro can improve the robustness and readability of the code, thus, I suggest replacing the numeric parameter with the macro.
*Scratches my head* The permissions are not 0444 below. With 1285 patches I wonder how many typos you may have made. Was this generated by a script? Eric
quoted hunk
Signed-off-by: Chuansheng Liu <redacted> Signed-off-by: Baole Ni <redacted> --- net/netfilter/ipset/ip_set_core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)diff --git a/net/netfilter/ipset/ip_set_core.c b/net/netfilter/ipset/ip_set_core.c index a748b0c..b6c060d3 100644 --- a/net/netfilter/ipset/ip_set_core.c +++ b/net/netfilter/ipset/ip_set_core.c@@ -48,7 +48,7 @@ static inline struct ip_set_net *ip_set_pernet(struct net *net) static unsigned int max_sets; -module_param(max_sets, int, 0600); +module_param(max_sets, int, S_IRUSR | S_IWUSR); MODULE_PARM_DESC(max_sets, "maximal number of sets"); MODULE_LICENSE("GPL"); MODULE_AUTHOR("Jozsef Kadlecsik <kadlec@blackhole.kfki.hu>");