Re: [PATCH 1083/1285] Replace numeric parameter like 0444 with macro
flat view
From: Steven Rostedt <rostedt@goodmis.org>
Date: 2016-08-02 13:28:00
Also in:
lkml
On Tue, 2 Aug 2016 20:14:55 +0800 Baole Ni [off-list ref] wrote:
I find that the developers often just specified the numeric value when calling a macro which is defined with a parameter for access permission. As we know, these numeric value for access permission have had the corresponding macro, and that using macro can improve the robustness and readability of the code, thus, I suggest replacing the numeric parameter with the macro.
NACK! I find 0444 more readable than S_IRUSR | S_IRGRP | S_IROTH. -- Steve
quoted hunk ↗ jump to hunk
Signed-off-by: Chuansheng Liu <redacted> Signed-off-by: Baole Ni <redacted> --- net/802/garp.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)diff --git a/net/802/garp.c b/net/802/garp.c index b38ee6d..ecc976a 100644 --- a/net/802/garp.c +++ b/net/802/garp.c@@ -22,7 +22,7 @@ #include <asm/unaligned.h> static unsigned int garp_join_time __read_mostly = 200; -module_param(garp_join_time, uint, 0644); +module_param(garp_join_time, uint, S_IRUSR | S_IWUSR | S_IRGRP | S_IROTH); MODULE_PARM_DESC(garp_join_time, "Join time in ms (default 200ms)"); MODULE_LICENSE("GPL");