Re: [patch iproute2 1/2] tc: Add support for the matchall traffic classifier.

On Mon, 22 Aug 2016 13:56:25 +0200
Jiri Pirko [off-list ref] wrote:

From: Yotam Gigi <redacted>

The matchall classifier matches every packet and allows the user to apply
actions on it. In addition, it supports the skip_sw and skip_hw (as can
be found on u32 and flower filter) that direct the kernel to skip the
software/hardware processing of the actions.

This filter is very useful in usecases where every packet should be
matched. For example, packet mirroring (SPAN) can be setup very easily
using that filter.

Signed-off-by: Yotam Gigi <redacted>
Signed-off-by: Jiri Pirko <redacted>

I am not a checkpatch purist, but these two should be addressed.


WARNING: unnecessary whitespace before a quoted newline
#81: FILE: tc/f_matchall.c:29:
+	fprintf(stderr, "Usage: ... matchall [skip_sw | skip_hw] \n");

WARNING: braces {} are not necessary for single statement blocks
#185: FILE: tc/f_matchall.c:133:
+	if (tb[TCA_MATCHALL_ACT]) {
+		tc_print_action(f, tb[TCA_MATCHALL_ACT]);
+	}