Thread (24 messages) 24 messages, 5 authors, 2016-09-09

Re: [PATCH v3 net-next 1/1] net_sched: Introduce skbmod action

From: Eric Dumazet <hidden>
Date: 2016-08-29 13:27:56

On Sun, 2016-08-28 at 22:10 -0700, Cong Wang wrote:
On Sun, Aug 28, 2016 at 9:07 AM, Eric Dumazet [off-list ref] wrote:
quoted
Adding an action with a spinlock held in fast path in 2016 is
a way to tell people : It is a toy, do not use it for real.

Sorry guys. Friends do not let friends do that anymore.
Please stop joking, this is not funny at all:

% git grep tcf_lock -- net/sched
This is absolutely trivial to write this skbmod without taking a lock.

If you guys do not care about that, I will simply NACK any new lazy
code.

Do not try to call me funny, simply acknowledge the mere facts and try
to keep your calm Cong.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help