Thread (2 messages) flat view 2 messages, 2 authors, 2016-08-25

Re: [PATCH] net: systemport: Fix ordering in intrl2_*_mask_clear macro

From: David Miller <hidden>
Date: 2016-08-25 23:53:05

From: Florian Fainelli <f.fainelli@gmail.com>
Date: Wed, 24 Aug 2016 14:21:41 -0700
Since we keep shadow copies of which interrupt sources are enabled
through the intrl2_*_mask_{set,clear} macros, make sure that the
ordering in which we do these two operations: update the copy, then
unmask the register is correct.

This is not currently a problem because we actually do not use them, but
we will in a subsequent patch optimizing register accesses, so better be
safe here.

Fixes: 80105befdb4b ("net: systemport: add Broadcom SYSTEMPORT Ethernet MAC driver")
Signed-off-by: Florian Fainelli <f.fainelli@gmail.com>
---
David,

This is intentionally targetting the "net-next" tree since it is
not yet a problem, yet this is still technically a bugfix. No need
to backport this to -stable or anything.
Fair enough, applied to net-next.

Thanks!
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help