Thread (23 messages) 23 messages, 8 authors, 2016-08-30

Re: [PATCH net-next V3 2/4] net/dst: Utility functions to build dst_metadata without supplying an skb

From: Shmulik Ladkani <hidden>
Date: 2016-08-25 16:41:09

Hi,

On Thu, 25 Aug 2016 19:13:45 +0300 Hadar Hen Zion [off-list ref] wrote:
From: Amir Vadai <redacted>

Extract _ip_tun_rx_dst() and _ipv6_tun_rx_dst() out of ip_tun_rx_dst()
and ipv6_tun_rx_dst(), to be used without supplying an skb.
Per this v3, the newly introduced helpers ate named _ip_tun_set_dst and
_ipv6_tun_set_dst - better alter the log message to reflect that.
+static inline struct metadata_dst *
+_ipv6_tun_set_dst(const struct in6_addr saddr, const struct in6_addr daddr,
+		  __u8 tos, __u8 ttl, __be32 label, __be16 flags,
+		  __be64 tunnel_id, int md_size)
+{
Any reason not passing in6_addr pointers, as suggested?
This is the common practice for ipv6 address parameters.

Thanks,
Shmulik
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help