Re: [PATCH -next] vmxnet3: fix non static symbol warning
From: Shrikrishna Khare <hidden>
Date: 2016-08-23 18:21:19
On Tue, 23 Aug 2016, Wei Yongjun wrote:
From: Wei Yongjun <redacted> Fixes the following sparse warning: drivers/net/vmxnet3/vmxnet3_drv.c:1645:1: warning: symbol 'vmxnet3_rq_destroy_all_rxdataring' was not declared. Should it be static? Signed-off-by: Wei Yongjun <redacted>
Thanks for catching and fixing this. The fix looks good. But, could you please send this against net tree instead of net-next?
quoted hunk ↗ jump to hunk
--- drivers/net/vmxnet3/vmxnet3_drv.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)diff --git a/drivers/net/vmxnet3/vmxnet3_drv.c b/drivers/net/vmxnet3/vmxnet3_drv.c index 4244b9d..2fd93b4 100644 --- a/drivers/net/vmxnet3/vmxnet3_drv.c +++ b/drivers/net/vmxnet3/vmxnet3_drv.c@@ -1641,7 +1641,7 @@ static void vmxnet3_rq_destroy(struct vmxnet3_rx_queue *rq,} } -void +static void vmxnet3_rq_destroy_all_rxdataring(struct vmxnet3_adapter *adapter) { int i;