Thread (2 messages) 2 messages, 2 authors, 2016-08-20

Re: [PATCH] net/irda: remove pointless assignment/check

flat view

From: David Miller <davem@davemloft.net>
Date: 2016-08-20 01:08:16

From: Vegard Nossum <redacted>
Date: Fri, 19 Aug 2016 18:08:57 +0200
We've already set sk to sock->sk and dereferenced it, so if it's NULL
we would have crashed already. Moreover, if it was NULL we would have
crashed anyway when jumping to 'out' and trying to unlock the sock.
Furthermore, if we had assigned a different value to 'sk' we would
have been calling lock_sock() and release_sock() on different sockets.

My conclusion is that these two lines are complete nonsense and only
serve to confuse the reader.

Signed-off-by: Vegard Nossum <redacted>
Applied.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help