Re: [PATCH v1 1/2] pptp: Use macro and sizeof instead of literal number
From: David Miller <davem@davemloft.net>
Date: 2016-08-19 21:39:30
From: fgao@ikuai8.com Date: Thu, 18 Aug 2016 12:47:34 +0800
quoted hunk ↗ jump to hunk
@@ -54,6 +54,8 @@ static struct proto pptp_sk_proto __read_mostly; static const struct ppp_channel_ops pptp_chan_ops; static const struct proto_ops pptp_ops; +static const u8 fixed_ppphdr[2] = {PPP_ALLSTATIONS, PPP_UI}; +
This makes things much worse in my opinion, and at the cost of two extra bytes in the data section as well. I'm not applying this.