Re: [RFC PATCH] openvswitch: use percpu flow stats
From: Eric Dumazet <hidden>
Date: 2016-08-19 19:56:56
On Fri, 2016-08-19 at 16:47 -0300, Thadeu Lima de Souza Cascardo wrote:
Instead of using flow stats per NUMA node, use it per CPU. When using megaflows, the stats lock can be a bottleneck in scalability.
...
flow_cache = kmem_cache_create("sw_flow", sizeof(struct sw_flow)
- + (nr_node_ids
+ + (num_possible_cpus()
* sizeof(struct flow_stats *)),
0, 0, NULL);
if (flow_cache == NULL)This is bogus. Please use nr_cpu_ids instead of num_possible_cpus(). _______________________________________________ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev