Thread (5 messages) flat view 5 messages, 3 authors, 2016-08-19

Re: [PATCH iproute2] ip route: restore_handler should check tb[RTA_PREFSRC] for local networks

From: Stephen Hemminger <stephen@networkplumber.org>
Date: 2016-08-19 02:11:16

On Sun,  7 Aug 2016 17:12:30 +0800
Xin Long [off-list ref] wrote:
Prior to this patch, If one route entry's RTA_PREFSRC and RTA_GATEWAY
both were NULL, it was supposed to be restored ONLY as a local address.

But as it didn't check tb[RTA_PREFSRC] when restoring local networks,
rtattr_cmp would return a success if it was NULL, this route entry would
be restored again as a local network.

This patch is to add tb[RTA_PREFSRC] check when restoring local networks.

Fixes: 74af8dd9620e ("ip route: restore route entries in correct order")
Signed-off-by: Xin Long <lucien.xin@gmail.com>
Applied
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help