Thread (4 messages) flat view 4 messages, 3 authors, 2016-08-15

Re: [PATCH net v2] net: ipv6: Fix ping to link-local addresses.

From: David Ahern <hidden>
Date: 2016-08-15 18:44:30

On 8/15/16 11:55 AM, David Miller wrote:
From: Lorenzo Colitti <redacted>
Date: Sat, 13 Aug 2016 01:13:38 +0900
quoted
ping_v6_sendmsg does not set flowi6_oif in response to
sin6_scope_id or sk_bound_dev_if, so it is not possible to use
these APIs to ping an IPv6 address on a different interface.
Instead, it sets flowi6_iif, which is incorrect but harmless.

Stop setting flowi6_iif, and support various ways of setting oif
in the same priority order used by udpv6_sendmsg.

Tested: https://android-review.googlesource.com/#/c/254470/
Signed-off-by: Lorenzo Colitti <redacted>
I'm expecting a new version of this patch with changes handling
the situation that VRF needs.
The vrf situation does not apply here - at least not yet. Maybe I am missing something but ping_v6_sendmsg does not support IPV6_PKTINFO, so the potential oif override of sk_bound_dev_if is not there.

I'll add this to the to-do list -- make IPv6 compatible with IPv4 wrt PKTINFO and then add in the VRF fix up discussed. 
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help