Re: [PATCH net v3] gre: set inner_protocol on xmit

On Mon, Aug 15, 2016 at 4:06 AM, Simon Horman
[off-list ref] wrote:

Ensure that the inner_protocol is set on transmit so that GSO segmentation,
which relies on that field, works correctly.

This is achieved by setting the inner_protocol in gre_build_header rather
than each caller of that function. It ensures that the inner_protocol is
set when gre_fb_xmit() is used to transmit GRE which was not previously the
case.

I have observed this is not the case when OvS transmits GRE using
lwtunnel metadata (which it always does).

Fixes: 38720352412a ("gre: Use inner_proto to obtain inner header protocol")
Cc: Pravin Shelar <redacted>
Acked-by: Alexander Duyck <redacted>
Signed-off-by: Simon Horman <redacted>
---
v3
* Move logic to gre_build_header() as suggested by Pravin Shelar.

v2
* Added Alexander's Ack
* Drop RFC designation
---

Acked-by: Pravin B Shelar <redacted>