Re: [Patch net v3 5/5] net_sched: convert tcf_exts from list to pointer array

On 16-08-14 01:03 AM, Cong Wang wrote:

On Sat, Aug 13, 2016 at 4:33 AM, Jamal Hadi Salim [off-list ref] wrote:

quoted

Just minor comment below:

On 16-08-11 08:41 PM, Cong Wang wrote:

quoted

+static inline void
+tcf_exts_to_list(const struct tcf_exts *exts, struct list_head *actions)
+{

to:
static inline void tcf_exts_to_list(const struct tcf_exts *exts,
                                    struct list_head *actions)

I don't disagree, just want to point out that other functions
in this header use similar indention. I am fine with either.

True - but if you introduce a new one you should use new style
(and it is an opportunity to fix the others).

Thanks for being dilligent on this. I dont have time to test the patches
for about a day but i see no reason to delay them, so I will proceed to
do so.

cheers,
jamal