Thread (3 messages) flat view 3 messages, 2 authors, 2016-08-12

Re: [PATCH/RFC net] gre: set inner_protocol on xmit

From: Simon Horman <hidden>
Date: 2016-08-12 15:15:26

On Fri, Aug 12, 2016 at 08:07:00AM -0700, Alexander Duyck wrote:
On Fri, Aug 12, 2016 at 2:46 AM, Simon Horman
[off-list ref] wrote:
quoted
Ensure that the inner_protocol is set on transmit so that GSO segmentation,
which relies on that field, works correctly.

I have observed this is not the case when OvS transmits GRE using
lwtunnel metadata (which it always does).

Fixes: 38720352412a ("gre: Use inner_proto to obtain inner header protocol")
Cc: Alexander Duyck <redacted>
Reviewed-by: Dinan Gunawardena <redacted>
Acked-by: Jakub Kicinski <redacted>
Signed-off-by: Simon Horman <redacted>
Looks good.  I'm surprised we had such a difference in how this was
handled between the flow based and device based paths.

Acked-by: Alexander Duyck <redacted>
Thanks, I have reposted with the above Ack and no RFC designation.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help