Thread (8 messages) 8 messages, 6 authors, 2016-08-10

Re: [PATCH net] bridge: Fix problems around fdb entries pointing to the bridge device

From: David Miller <davem@davemloft.net>
Date: 2016-08-10 04:51:28
Also in: bridge

From: Toshiaki Makita <redacted>
Date: Thu,  4 Aug 2016 11:11:19 +0900
Adding fdb entries pointing to the bridge device uses fdb_insert(),
which lacks various checks and does not respect added_by_user flag.

As a result, some inconsistent behavior can happen:
* Adding temporary entries succeeds but results in permanent entries.
* Same goes for "dynamic" and "use".
* Changing mac address of the bridge device causes deletion of
  user-added entries.
* Replacing existing entries looks successful from userspace but actually
  not, regardless of NLM_F_EXCL flag.

Use the same logic as other entries and fix them.

Fixes: 3741873b4f73 ("bridge: allow adding of fdb entries pointing to the bridge device")
Signed-off-by: Toshiaki Makita <redacted>
Applied, thanks.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help