Thread (29 messages) flat view 29 messages, 3 authors, 2016-09-02

Re: [PATCH RESEND net-next 15/15] smc: proc-fs interface for smc connections

From: David Miller <davem@davemloft.net>
Date: 2016-08-09 21:40:49
Also in: linux-s390

From: Ursula Braun <redacted>
Date: Tue,  9 Aug 2016 12:13:00 +0200
+	sock_hold(&smc->sk);
 ...
+out_line:
+	seq_putc(m, '\n');
+	sock_put(&smc->sk);
You hold the smc_proc_list_lock during this function's execution,
therefore the table cannot change and therefore the socket cannot
go away.

Therefore taking a reference count here is unnecessary overhead,
please remove it.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help