Thread (3 messages) flat view 3 messages, 2 authors, 2016-08-05

Re: [PATCH] VSOCK: fix vhost virtio_vsock_pkt use-after-free

From: Stefan Hajnoczi <stefanha@redhat.com>
Date: 2016-08-05 08:52:31
Also in: kvm

On Thu, Aug 04, 2016 at 07:34:43PM +0300, Michael S. Tsirkin wrote:
On Thu, Aug 04, 2016 at 02:52:53PM +0100, Stefan Hajnoczi wrote:
quoted
Stash the packet length in a local variable before handing over
ownership of the packet to virtio_transport_recv_pkt() or
virtio_transport_free_pkt().

This patch solves the use-after-free since pkt is no longer guaranteed
to be alive.

Reported-by: Dan Carpenter <redacted>
Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>

Thanks!
I'd prefer a lower-case prefix, mentioning vhost, such as vhost/vsock.
I'll tweak it for now.
Thanks, I will use vhost/vsock in the future.

Stefan

Attachments

Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help