Thread (6 messages) 6 messages, 3 authors, 2016-07-31

RE: [PATCH] qed: Add and use specific logging functions to reduce object size

From: Yuval Mintz <hidden>
Date: 2016-07-27 09:38:05
Also in: lkml

quoted
Current DP_ macros generate a lot of code.
Using functions with vsprintf extension %pV helps reduce that size.
Yuval, I used the same KERN_<LEVEL> output types, but it is unusual
that DP_INFO outputs at KERN_NOTICE.

Was that a copy/paste defect or should it be emitted at KERN_INFO and
DP_VERBOSE be emitted at KERN_DEBUG?
I agree it's a bit odd, but it's actually by design - 
as none of these prints would ever be reached unless user explicitly enable
them [ethtool/module param], the assumption is that NOTICE is good
enough, i.e., it will prevent the need for doing additional configuration of
logging levels by the user.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help