Thread (11 messages) flat view 11 messages, 3 authors, 2016-07-27

Re: [PATCH v18 net-next 1/1] hv_sock: introduce Hyper-V Sockets

From: David Miller <davem@davemloft.net>
Date: 2016-07-26 00:37:08
Also in: lkml

From: Dexuan Cui <decui@microsoft.com>
Date: Sat, 23 Jul 2016 01:35:51 +0000
+static struct sock *hvsock_create(struct net *net, struct socket *sock,
+				  gfp_t priority, unsigned short type)
+{
+	struct hvsock_sock *hvsk;
+	struct sock *sk;
+
+	sk = sk_alloc(net, AF_HYPERV, priority, &hvsock_proto, 0);
+	if (!sk)
+		return NULL;
 ...
+	/* Looks stream-based socket doesn't need this. */
+	sk->sk_backlog_rcv = NULL;
+
+	sk->sk_state = 0;
+	sock_reset_flag(sk, SOCK_DONE);
All of these are unnecessary initializations, since sk_alloc() zeroes
out the 'sk' object for you.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help