Re: [PATCH net-next v2] cdc_ether: Improve ZTE MF823/831/910 handling

On Tue, Jul 19, 2016 at 2:33 PM, Oliver Neukum [off-list ref] wrote:

On Tue, 2016-07-19 at 13:49 +0200, Kristian Evensen wrote:

quoted

@@ -428,10 +434,47 @@ int usbnet_cdc_bind(struct usbnet *dev, struct

usb_interface *intf)
                return status;
        }

+       if (dev->net->dev_addr[0] & 0x02)
+               eth_hw_addr_random(dev->net);
+
        return 0;
 }
 EXPORT_SYMBOL_GPL(usbnet_cdc_bind);

+static int usbnet_cdc_zte_bind(struct usbnet *dev, struct
usb_interface *intf)
+{
+       int status = usbnet_cdc_bind(dev, intf);
+
+       if (status)
+               return status;
+
+       if (dev->net->dev_addr[0] & 0x02)
+               eth_hw_addr_random(dev->net);
+
+       return 0;
+}

That really makes no sense.

Ops, my bad. Thanks for catching it. The check for random hw_addr
should only be in the zte_bind() function.

-Kristian