Thread (2 messages) flat view 2 messages, 2 authors, 2016-07-05

Re: [PATCH] fsl/fman: fix error handling

From: David Miller <davem@davemloft.net>
Date: 2016-07-05 00:18:48
Also in: kernel-janitors, lkml

From: Christophe JAILLET <redacted>
Date: Mon,  4 Jul 2016 07:46:42 +0200
This is likely that checking 'fman->fifo_offset' instead of
'fman->cam_offset' is expected here.

Signed-off-by: Christophe JAILLET <redacted>
---

The type of 'fifo_offset' may also need to be changed.
Fix the test rather than trying to force it into the error pointer
macro.

If fifo_offset is not a pointer, then change the test to check for
whatever would be appropriate for values returned from
fman_muram_alloc().

This is a very low quality patch submission, you submitted a "fix"
which added a new build warning and made it obvious that something
else is needed as well here.  You even stated that you realized this.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help