Thread (3 messages) 3 messages, 3 authors, 2016-07-31

Re: [PATCH -next] drivers: net: phy: xgene: Remove redundant dev_err call in xgene_mdio_probe()

From: Iyappan Subramanian <hidden>
Date: 2016-07-28 20:42:20

On Wed, Jul 27, 2016 at 7:12 PM, Wei Yongjun [off-list ref] wrote:
quoted hunk ↗ jump to hunk
There is a error message within devm_ioremap_resource
already, so remove the dev_err call to avoid redundant
error message.

Signed-off-by: Wei Yongjun <redacted>
---
 drivers/net/phy/mdio-xgene.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/net/phy/mdio-xgene.c b/drivers/net/phy/mdio-xgene.c
index d94a978..7756748 100644
--- a/drivers/net/phy/mdio-xgene.c
+++ b/drivers/net/phy/mdio-xgene.c
@@ -345,10 +345,8 @@ static int xgene_mdio_probe(struct platform_device *pdev)

        res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
        csr_base = devm_ioremap_resource(dev, res);
-       if (IS_ERR(csr_base)) {
-               dev_err(dev, "Unable to retrieve mac CSR region\n");
+       if (IS_ERR(csr_base))
                return PTR_ERR(csr_base);
-       }
        pdata->mac_csr_addr = csr_base;
        pdata->mdio_csr_addr = csr_base + BLOCK_XG_MDIO_CSR_OFFSET;
        pdata->diag_csr_addr = csr_base + BLOCK_DIAG_CSR_OFFSET;

Thanks.

Acked-By: Iyappan Subramanian <redacted>
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help