Thread (10 messages) flat view 10 messages, 2 authors, 2016-07-27

Re: [net-next PATCH 4/4] be2net: replace polling with sleeping in the FW completion path

From: David Miller <davem@davemloft.net>
Date: 2016-07-25 17:51:31

From: Sathya Perla <redacted>
Date: Fri, 22 Jul 2016 06:55:46 -0400
quoted hunk ↗ jump to hunk
@@ -4477,6 +4551,22 @@ static int be_if_create(struct be_adapter *adapter)
 	u32 cap_flags = be_if_cap_flags(adapter);
 	int status;
 
+	/* alloc required memory for other filtering fields */
+	adapter->pmac_id = kcalloc(be_max_uc(adapter),
+				   sizeof(*adapter->pmac_id), GFP_KERNEL);
+	if (!adapter->pmac_id)
+		return -ENOMEM;
+
+	adapter->mc_list = kcalloc(be_max_mc(adapter),
+				   sizeof(*adapter->mc_list), GFP_KERNEL);
+	if (!adapter->mc_list)
+		return -ENOMEM;
+
+	adapter->uc_list = kcalloc(be_max_uc(adapter),
+				   sizeof(*adapter->uc_list), GFP_KERNEL);
+	if (!adapter->uc_list)
+		return -ENOMEM;
These error paths are leaking memory, please audit this in the rest of your
change as well.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help