Re: [PATCH iproute 0/5] iproute: ila and fou additions

On Thu, 14 Jul 2016 12:22:11 -0700
Tom Herbert [off-list ref] wrote:

Patch set includes:

- Allow configuring checksum mode for ila LWT (e.g. configure
  checksum neutral
- Configuration for performing ila translations using netfilter hook
- fou encapsulation for ip6tnl and gre6
- fou listener for IPv6

*** SUBJECT HERE ***

*** BLURB HERE ***

Tom Herbert (5):
  ila: Support for checksum neutral translation
  ila: Support for configuring ila to use netfilter hook
  ip6tnl: Support for fou encapsulation
  gre6: Support for fou encapsulation
  fou: Allowing configuring IPv6 listener

 ip/Makefile           |   2 +-
 ip/ip.c               |   3 +-
 ip/ip_common.h        |   1 +
 ip/ipfou.c            |   8 +-
 ip/ipila.c            | 259 ++++++++++++++++++++++++++++++++++++++++++++++++++
 ip/iproute_lwtunnel.c |  57 ++++++++++-
 ip/link_gre6.c        | 101 ++++++++++++++++++++
 ip/link_ip6tnl.c      |  92 +++++++++++++++++-
 8 files changed, 516 insertions(+), 7 deletions(-)
 create mode 100644 ip/ipila.c

I am okay with the content of these patches, but they have have lots of style issues.

1. Bad indentation in several spots
2. Lines are too long
3. Use rta_getattr_u64, look for places that access RTA_DATA() directly
5. Run checkpatch