Re: [PATCH net-next v11 3/6] openvswitch: set skb protocol and mac_len when receiving on internal device
From: pravin shelar <hidden>
Date: 2016-07-07 20:52:25
On Wed, Jul 6, 2016 at 10:59 AM, Simon Horman [off-list ref] wrote:
* Set skb protocol based on contents of packet. I have observed this is necessary to get actual protocol of a packet when it is injected into an internal device e.g. by libnet in which case skb protocol will be set to ETH_ALL.
I am not sure what do yo mean by ETH_ALL. I could not find it in the kernel. anyways, Can we fix libnet to set skb->protocol field correctly? The change is introducing overhead for every packet received on internal port.
* Set the mac_len which has been observed to not be set up correctly when an ARP packet is generated and sent via an openvswitch bridge. My test case is a scenario where there are two open vswtich bridges. One outputs to a tunnel port which egresses on the other. The motivation for this is that support for outputting to layer 3 (non-tap) GRE tunnels as implemented by a subsequent patch depends on protocol and mac_len being set correctly on receive.
The commit msg and the change does not match anymore.
quoted hunk
Signed-off-by: Simon Horman <redacted> --- v11 * Do not set mac_len. Instead of relying on mac_len follow-up patches now use skb_unset_mac_header() v10 * Set mac_len v9 * New patch --- net/openvswitch/vport-internal_dev.c | 3 +++ 1 file changed, 3 insertions(+)diff --git a/net/openvswitch/vport-internal_dev.c b/net/openvswitch/vport-internal_dev.c index 434e04c3a189..32d8e94d9bff 100644 --- a/net/openvswitch/vport-internal_dev.c +++ b/net/openvswitch/vport-internal_dev.c@@ -48,6 +48,9 @@ static int internal_dev_xmit(struct sk_buff *skb, struct net_device *netdev) { int len, err; + skb->protocol = eth_type_trans(skb, netdev); + skb_push(skb, ETH_HLEN); +
_______________________________________________ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev